Repository navigation
SVG: read a missing coordinate of a <line> as 0 - #2167
Merged
andersonhc merged 2 commits intoNov 12, 2026
Merged
Conversation
andersonhc
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<line>without one ofx1,y1,x2ory2fails with aKeyError:In the SVG specification the initial value of each of the four is 0. D3 relies on that: every tick of a D3 axis is written with only
y2(orx2), as<line stroke="currentColor" y2="6"></line>(tickEnter.append("line").attr(x + "2", k * tickSizeInner)in d3-axis), so an SVG export of a D3 chart could not be converted.ShapeBuilder.line()now reads a missing coordinate as"0", ascircle()andellipse()already do forcxandcy.The
line no x1case oftest_svg_shape_tagsexpected theKeyError; it now expects the line from (0, 0), and a newline only y2case covers a D3 tick. Both fail on master. The SVG tests, black and pylint pass