Repository navigation
SVG: read a gradient <stop> without offset as offset 0 - #2164
Merged
andersonhc merged 1 commit intoNov 11, 2026
Merged
Conversation
|
This matches the SVG spec: |
andersonhc
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<stop>without anoffsetis skipped with the warning "Found without offset, skipping". Butoffsetis optional: its initial value is 0, so such a stop starts the gradient.The Hugging Face Hub logo on spaCy's website (
website/src/images/logos/huggingface_hub.svg) and spaCy'spipeline-design.svgboth write their first stop like this:so the text of the Hugging Face logo comes out flat black instead of going from navy to black.
_parse_gradient_stops()now reads a missing offset as 0.test_gradient_stop_without_offsetchecks that both stops are read; it fails on master. The SVG tests, black, pylint, mypy and pyright pass