Repository navigation
SVG: do not draw an element with display="none" - #2158
Merged
Merged
Conversation
RavSinghChandan
force-pushed
the
svg-display-none
branch
from
November 10, 2026 13:05
399ccf7 to
8b75beb
Compare
RavSinghChandan
force-pushed
the
svg-display-none
branch
from
November 10, 2026 14:10
8b75beb to
9b952d8
Compare
andersonhc
requested changes
Nov 11, 2026
andersonhc
left a comment
andersonhc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding this! The hidden-layer handling looks useful, and the tests cover the common cases well.
I noticed a few cases where hidden content still appears:
- display="none" on the root or a is missed because those elements don’t go through _build_group_child().
- A referencing an element that itself has display="none" still draws it. This differs from referencing a visible child inside a hidden group, which your new test correctly allows.
Could we cover these cases too? For references, we’ll need to preserve the target’s own display setting while keeping visible descendants of hidden groups available for reuse.
Author
|
Thanks, all three are covered now: a hidden root or is not drawn, and a of an element that is itself display="none" draws nothing, while a visible element inside a hidden group can still be reused. |
andersonhc
approved these changes
Nov 12, 2026
# Conflicts: # CHANGELOG.md # fpdf/svg.py # test/svg/test_svg.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements and groups with
display="none"are drawn. Inkscape stores hidden layers as<g style="display:none">, and other editors writedisplay="none"on hidden objects, so content the author hid ends up in the PDF. tox's logo (docs/_static/img/tox.svg) has a hidden layer, and optax's favicon (docs/images/favicon.svg) has a hidden group of construction strokes, which are written into the PDF (146 kB with them, 118 kB without)._build_group_child()now readsdisplay(attribute,styleor CSS class) and builds a hidden element into a throwaway group, so it is not drawn, but its ids are still registered and a<use>of an element inside it still works.Added
test_svg_display_none(attribute, hidden Inkscape layer, CSS class) andtest_svg_display_none_referenced; the first fails on master. The full test suite passes excepttest_image_with_explicit_dimensions, which also fails on master in my environment; black, pylint, mypy and pyright pass