Repository navigation
SVG: handle empty path data like a path without d - #2144
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 10, 2026
RavSinghChandan
force-pushed
the
svg-empty-path-data
branch
from
November 10, 2026 04:01
86b48a8 to
77d8549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<path d="">fails withValueError: Path does not start with move item. SVG says empty path data disables rendering of the path; it is not an error.This comes from real tools: PyMuPDF's
Page.get_svg_image()writes<path d=""/>for empty clips (its test outputtests/test_4846_out.svgfails to load in fpdf2), and so do ezdxf's documentation drawings.parse_path()already rejects path data that does not start with a moveto, with its own error, so the check insvg_path_converter()was only reached for empty data, wherefirst_is_movestaysNone. It now raises only whenfirst_is_moveisFalse, so an emptydgives the same empty path as a<path>withoutd.Added
test_path_empty_data(""and whitespace) andtest_path_not_starting_with_move, which checks that invalid path data still raises; the first fails on master.pytest test/svg test/drawing, black, pylint and mypy pass