Repository navigation
text: raise a clear error for a NaN or infinite position - #2141
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.text(x, y, ...)writes a NaN or infinite position straight into the content stream, which is not a valid PDF number:set_x(),set_y()andset_xy()already reject these with_check_coordinate()(#2121), sotext()now calls the same helper forxandy, before anything is written. Finite positions, including negative ones, are unchanged.This does not overlap with #2139, which covers
line(),polyline(),polygon(),ellipse()andcircle().Added
test_text_not_finite_position(NaN, inf and -inf, forxand fory); it fails on master. The full test suite passes excepttest_image_with_explicit_dimensions, which also fails on master in my environment