Repository navigation
LinearGradient/RadialGradient: raise a clear error for bounds outside [0, 1] or decreasing - #2134
Merged
Merged
Conversation
RavSinghChandan
force-pushed
the
gradient-bounds-range
branch
from
November 9, 2026 13:23
3e80f38 to
f2937d3
Compare
andersonhc
approved these changes
Nov 9, 2026
… [0, 1] or decreasing
RavSinghChandan
force-pushed
the
gradient-bounds-range
branch
from
November 9, 2026 14:50
f2937d3 to
0b28c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinearGradient(..., bounds=[1.5, 0.8])wrote/Bounds [1.5 0.8]into the stitching function, and[-0.2, ...], decreasing values or NaN went through the same way. The PDF specification requires the bounds to be increasing and within the function's domain [0, 1], and the docstring already says they are "in the range (0, 1)".The gradient now raises
ValueError: Bounds must be increasing numbers between 0 and 1: ..., next to the existing check on the number of bounds. Equal bounds and bounds of exactly 0 or 1 are still accepted, so the gradients built from SVG andshape_*_gradient()stops are unchanged.CHANGELOG.md