Repository navigation
drawing: omit an arc whose end point is its start point, like SVG - #2132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SVG path with an arc that ends where it starts, such as
M10 10 A5 5 0 0 0 10 10, madepdf.image()fail withZeroDivisionError: float division by zeroinArc._approximate_arc(). The same happened forPaintedPath.arc_to()back to the current point.The SVG specification says such an arc is omitted ("If the endpoints are identical, then this is equivalent to omitting the elliptical arc segment entirely", SVG 1.1 F.6.2).
_approximate_arc()now returns no curves for it, andArc.render()already draws nothing for an empty list.Added two cases to
svg_path_render_tests(absolute and relative arc); they fail on master with theZeroDivisionError.CHANGELOG.md