Repository navigation
GraphicsStyle: reject a NaN or infinite stroke dash pattern or phase - #2117
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 7, 2026
andersonhc
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SVG with
stroke-dasharray="nan 2"wrote[nan 2] 0 dinto the page, andstroke-dashoffset="inf"an infinite phase; neither is a valid PDF number. The same happened when setting them directly on aGraphicsStyle.GraphicsStyle.stroke_dash_patternandstroke_dash_phasenow raise aValueErrorfor NaN or infinity, likeFPDF.set_dash_pattern()does since #2103. As the SVG parser goes through these setters, an SVG with such a value now raises like one withstroke-dasharray="bad".Tests added to the invalid style parameters and the SVG attribute conversion tests (they fail on master).
CHANGELOG.md