Repository navigation
set_page_background: raise a clear error for an invalid color - #2101
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_page_background()stored any tuple, and an invalid color only failed on the nextadd_page(), far from the call that set it:(300, 0, 0)->ValueError: color component 300 not in range [0, 255]fromadd_page()(10, 20)->ValueError: color component -1 not in range [0, 255], a value that was never passed(10, 20, 30, 40)->TypeError: FPDF.set_fill_color() takes from 2 to 4 positional arguments but 5 were givenA color tuple is now checked when it is set, like
set_fill_color()checks its components: 1 (grey level) or 3 values, each in [0, 255]. The previous background is kept when the new one is invalid.CHANGELOG.md