Repository navigation
add_link/set_link: raise a clear error for a negative page - #2095
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative
pageother than -1 (the current page) was stored as is, and the page reference was then taken from the end of the page list: in a 3-page document,add_link(page=-2)silently pointed to page 1. In a shorter document it failed atoutput()with a bareIndexError.add_link()andset_link()(including named destinations) now raiseValueError: Invalid page number for a link: -2 - use -1 for the current page. A page of 0 (no page yet) is unchanged, as it is used by links set later withset_link().CHANGELOG.md