Repository navigation
set_font: raise a clear error for a negative font size - #2083
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_font(size=-12)andset_font_size(-12)wrote a negative font size: the text was mirrored and each line ofmulti_cell()moved up the page, above the top margin. Both now raiseValueError: Font size must be zero or a positive number, likeset_line_width()does for a negative width. A size of 0 still means "keep the current size" inset_font().So that
write_html()does not start raising, it ignores a negative<font size>or CSSfont-size, like browsers, and keeps the current size.CHANGELOG.md