Repository navigation
regular_polygon: raise a clear error for numSides below 1 - #2069
Merged
andersonhc merged 1 commit intoOct 28, 2026
Merged
Conversation
andersonhc
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.regular_polygon()withnumSides=0or a negative value computed no vertices and passed an empty list topolygon(), which wrote a path with no points: the content stream got a bareh S, closing a path that was never started (there is nombefore it), and no error was raised.It now raises
ValueError: 'numSides' parameter must be equal or greater than 1: 0, using the same wording asinsert_toc_placeholder()forpagesand #2066 forstar(). Addedtest_regular_polygon_invalid_num_sidesintest/shapes/test_regular_polygon.py, and a CHANGELOG entry.