Repository navigation
page labels: raise a clear error for label_start below 1 - #2067
Merged
andersonhc merged 1 commit intoOct 28, 2026
Merged
Conversation
andersonhc
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.add_page()andFPDF.set_page_label()accepted anylabel_startand wrote it as the page label/Stvalue, solabel_start=0or-2produced/St 0or/St -2. The PDF specification (ISO 32000, page label dictionary) requiresStto be an integer greater than or equal to 1.Both methods now raise
ValueError: 'label_start' parameter must be equal or greater than 1: 0before changing any state. Addedtest_page_label_start_below_onenext totest_page_label, and noted the rule in theadd_page()docstring.