Repository navigation
raise a ValueError for an internal link that add_link() did not create - #2059
Merged
andersonhc merged 1 commit intoOct 25, 2026
Merged
Conversation
andersonhc
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.link()(used bycell(),multi_cell(),write()andimage()) checked an integer link with anassert, so a link thatadd_link()did not return, such ascell(text="Page 1", link=999), raised a bareAssertionError, and withpython -Othe assert is removed and it became aKeyError. The neighbouring check for a link without a page number already raises aValueError.It now raises
ValueError: Link with an invalid index: 999 (doc #links=0) - internal links must be created with add_link(). Added a test next totest_inserting_link_with_no_page_number.