Repository navigation
SVG: draw polygon and polyline points up to the last complete pair - #2000
Merged
andersonhc merged 2 commits intoOct 11, 2026
Merged
Conversation
andersonhc
requested changes
Oct 11, 2026
Author
|
Good catch, thanks! It now reads the points in order and stops at the first error, so nothing after it is drawn: "1,0 10,10 x 20,20" draws only up to 10,10, and a doubled comma stops it the same way. A trailing odd coordinate is still dropped. I added tests for both, which fail on the previous version. |
andersonhc
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<polygon>or<polyline>with an odd number of coordinates (likepoints="0,0 10,10 20") or empty points crashed withIndexError: pop from empty list. The SVG spec says to draw up to the last complete pair, and draw nothing for empty points. Now it does that. Valid shapes draw the same as before. Added tests.e.g. Fixes #0
Checklist:
A unit test is covering the code added / modified by this PR
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdThis PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.