Repository navigation
write_html: support <ul type="square"> instead of raising NotImplemen… - #1989
Merged
Merged
Conversation
andersonhc
approved these changes
Oct 10, 2026
andersonhc
left a comment
andersonhc
left a comment
Collaborator
There was a problem hiding this comment.
Thank you. Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<ul type="square">madewrite_html()raiseNotImplementedError: Unsupported type: square, although "square" is one of the three standard HTML bullet types next to "disc" and "circle", which are already supported.It now renders the way "circle" does: Unicode fonts use ▪ (U+25AA BLACK SMALL SQUARE), and core fonts, whose Windows-1252 encoding has no square, fall back to the bullet. The
ul_bullet_chardocstring now lists "square" too.Checklist:
docs/folder (docstring updated)CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.