Repository navigation
write_html: continue lettered list markers past z instead of raising … - #1987
Merged
andersonhc merged 3 commits intoOct 10, 2026
Merged
Conversation
andersonhc
requested changes
Oct 10, 2026
Author
|
Done, thanks! int_to_letters() now uses the iterative divmod version with the same zero-based interface (it gives identical results to the old one for 0-199999, so page labels are unchanged), and ol_prefix() calls it, returning the index as-is below 1 and lowercasing for type="a". I removed _alphabetic() and added a small test for int_to_letters(). Thanks also for the typos.toml fix. |
andersonhc
approved these changes
Oct 10, 2026
andersonhc
left a comment
andersonhc
left a comment
Collaborator
There was a problem hiding this comment.
Ready to merge. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any
<ol type="a">or<ol type="A">list with more than 26 items madewrite_html()raiseIndexError: string index out of range, becauseol_prefix()indexedascii_lowercasedirectly. A list withstart="26"failed on its second item.Lettered markers now continue the way browsers render them: a … z, aa, ab … az, ba, and so on. A
startbelow 1 shows as a number, as browsers do; before,start="0"printed "z".Checklist:
docs/folder (N/A, bug fix)CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.