Accept Uint8Array#47
Merged
pvorb merged 1 commit intopvorb:masterfrom Sep 15, 2018
tyfkda:feature/uint8array
Merged
Conversation
Owner
|
Thanks. Please fix the unit tests. |
Contributor
Author
|
Thank you for your comment. I've fixed the unit test, |
Contributor
Author
|
Added note to README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pvorb ,
I want this library to accept
Uint8Array.It seems the library already accept
Array,and
Uint8Arrayis also handled as well.I don't have necessity for other typed arrays (
Uint8ClampedArray, etc...),so added
Uint8Arrayonly.