fix undefined check so that we can hash the string 'undefined'#31
Merged
pvorb merged 2 commits intopvorb:masterfrom Aug 31, 2016
stevejhiggs:allowHashingStringUndefined
Merged
fix undefined check so that we can hash the string 'undefined'#31pvorb merged 2 commits intopvorb:masterfrom stevejhiggs:allowHashingStringUndefined
pvorb merged 2 commits intopvorb:masterfrom
stevejhiggs:allowHashingStringUndefined
Conversation
Contributor
Author
|
the original undefined check would have thrown an error when hashing the string "undefined" which is a legitimate value to hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29