You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c1426b9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(agents): apply agent manifest settings per sandbox
The agent launcher applied manifest settings with `settings set --global`,
so every gator launch switched proposal_approval_mode to auto for the whole
gateway. Apply them to the launched sandbox after creation instead. If a
gateway-global value already manages a key, warn and leave it in effect.
Related to NVIDIA#3469.
Signed-off-by: Jim Meyer <[email protected]>
Copy file name to clipboardExpand all lines: scripts/agents/gator/README.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -98,7 +98,7 @@ Use `--harness codex` to select Codex explicitly. Other harness names are reject
98
98
99
99
Use `--codex-bin "$(command -v codex)"` only when the host executable is compatible with the sandbox OS and architecture.
100
100
101
-
The manifest-driven launcher at `scripts/agents/run.sh` reads `agent.yaml`, which defines the versioned immutable payload, prompt template, provider profile IDs, provider credential sources, gateway settings, skills, subagents, supporting resources, sandbox defaults, runtime mode, and harness defaults. The shared sandbox entrypoint at `scripts/agents/runtime/entrypoint.sh` starts the in-sandbox supervisor, which invokes the selected harness adapter for bounded cycles.
101
+
The manifest-driven launcher at `scripts/agents/run.sh` reads `agent.yaml`, which defines the versioned immutable payload, prompt template, provider profile IDs, provider credential sources, sandbox settings, skills, subagents, supporting resources, sandbox defaults, runtime mode, and harness defaults. The shared sandbox entrypoint at `scripts/agents/runtime/entrypoint.sh` starts the in-sandbox supervisor, which invokes the selected harness adapter for bounded cycles.
102
102
103
103
The launcher:
104
104
@@ -109,7 +109,7 @@ The launcher:
109
109
- For `--harness codex`, imports `providers/codex-gator.yaml`, creates or updates the `codex-gator` provider from `$HOME/.codex/auth.json`, and stores the refresh token as gateway-only refresh material.
110
110
- For `--harness codex`, configures gateway-managed refresh for `CODEX_AUTH_ACCESS_TOKEN` and rotates it before launching the sandbox.
111
111
- Passes the non-secret Codex account ID from host auth as `CODEX_ACCOUNT_ID`. The harness writes it literally into `auth.json` for local workspace discovery; access tokens remain opaque provider placeholders and refresh tokens remain gateway-only.
112
-
- Enables `agent_policy_proposals_enabled` and `proposal_approval_mode=auto`at gateway scope.
112
+
- Enables `agent_policy_proposals_enabled` and `proposal_approval_mode=auto`on the gator sandbox only. Gateway-global values for these keys take precedence; the launcher does not change them.
113
113
- Uses the gator image policy copied to `/etc/openshell/policy.yaml`.
114
114
- Installs the gator-specific `gh` wrapper from `gator/bin/gh` as `/usr/local/bin/gh` to fail closed when same-head-SHA history cannot be checked, prevent duplicate dispositions, and require versioned review payloads.
115
115
- Installs `gator/bin/review-feedback-ledger` as `/usr/local/bin/review-feedback-ledger` so reviews receive tree- and patch-aware scope, prior summaries and findings, resolution state, convergence telemetry, and the three-round Warning budget.
0 commit comments