Fix memoized #743
Merged
Fix memoized #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If desired, I could also add a new example that demonstrates the |
Member
|
Did you test it that way already after updating the implementation? I'm fine to skip including that in here, but it'd be good to know that it has been seen to work when we merge this 😄 |
Member
Author
|
I adjusted the existing components-inputs example to make sure this works :) I’d like to add a new example, though, just so we can more easily test in the future. |
Member
Author
|
#747 demonstrates that this update does indeed fix the |
garyb
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742 by using the same non-eta-expanded implementation as Spork. I tested this locally by updating the
components-inputsexample to use the previous implementation and the Spork implementation and could verify that thememoizedfunction only works when done the Spork way.