This repository was archived by the owner on Jun 5, 2022. It is now read-only.
Closed
Conversation
The polyfills use naive method for calculation, and subject to loss of precision and undue overflow. If you want precision on old browsers, you should load a better polyfill beforehand.
This was referenced Dec 6, 2018
Closed
Closed
Contributor
|
I'm taking a look at this now. Since this is a core library, how does this affect other backends? If this would potentially be forcing JS-specific stuff onto other backends, then this should be exported as a separate library. For the polyfill issue, one could use a similar approach to what was decided in purescript-contrib/purescript-arraybuffer#34 (comment) |
Contributor
|
Actually, based on the discussion in #31, this should be ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more ES6 functions, expanding #18. They include:
acosh,asinh,atanhcosh,sinh,tanhexpm1log1p,log10,log2cbrtclz32hypothypot3signPolyfills are provided for the old browesers, but they use naive method for calculation, and subject to loss of precision and undue overflow. People who mind numeric precision should load a better polyfill. (Maybe this should be documented?)
Among Math functions added in ES6,
Math.froundis left out, because I think it is of little value without a type likeFloat32.