Add an isSpace test for a CJK character#36
Merged
thomashoneyman merged 2 commits intopurescript-contrib:mainfrom Nov 8, 2021
Merged
Conversation
thomashoneyman
approved these changes
Nov 8, 2021
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds a test for
isSpaceusing a CJK character.An issue with CJK characters when used with
isSpacewas previously reported in #20. The issue is no longer reproducible onmain, but it's probably good to have some test coverage for this path to ensure there are no regressions.Closes #20.
Checklist: