Update to v0.14.0-rc3#30
Merged
JordanMartinez merged 5 commits intopurescript-contrib:mainfrom Dec 4, 2020
JordanMartinez:updateTo14
Merged
Update to v0.14.0-rc3#30JordanMartinez merged 5 commits intopurescript-contrib:mainfrom JordanMartinez:updateTo14
JordanMartinez merged 5 commits intopurescript-contrib:mainfrom
JordanMartinez:updateTo14
Conversation
Contributor
Author
|
This has a dependency on |
Contributor
|
While not super fun, we can migrate this to use assert instead of I also don't see |
Contributor
Author
|
I worked around the tests issue. How's this? |
thomashoneyman
approved these changes
Dec 3, 2020
test/Test/Data/Char/Unicode.purs
Outdated
Comment on lines
18
to
19
| -- import Test.Spec (Spec, describe, it) | ||
| -- import Test.Spec.Assertions (shouldEqual) |
Contributor
There was a problem hiding this comment.
Suggested change
| -- import Test.Spec (Spec, describe, it) | |
| -- import Test.Spec.Assertions (shouldEqual) |
Contributor
Author
There was a problem hiding this comment.
Pushed a commit fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlinking to purescript-contrib/governance#35