Update according to Contributors library guidelines#26
Conversation
|
This build is failing because several of the tests fail due to an "illegal space character." These characters were disallowed in version 0.13.x of the PureScript compiler. @cdepillabout (or anyone else I should ask?), do you have suggestions on how to handle these tests? |
|
@thomashoneyman Thanks for sending this PR! Everything looks good here.
I took a quick look at the tests, but CI appears to be failing on commit 0aaa87b with the following error (https://github.com/purescript-contrib/purescript-unicode/runs/1212618133#step:8:71): It sounds like escaped characters like Otherwise, I'd be completely fine with just disabling the tests for now and adding an issue about re-enabling them when someone has time to figure out a fix. |
|
Sorry, I misspoke — this is the error I was referring to, and no I unfortunately don’t know how to generate that character for the purpose of the tests. I can disable just the affected three or so tests and open an issue to look into re-enabling them. |
That sounds like the easiest thing to do for now. Other than that, I think this looks good. |
This pull request is part of an effort to update and standardize the Contributors libraries according to the Library Guidelines. Specifically, it:
testdirectory.This PR is the groundwork for followup efforts to ensure contributor libraries are kept up-to-date, documented, tested, and accessible to users and new contributors.