Conversation
|
I'll have a look over this this week, thanks! You should run your generator script though, no? And perhaps a test file would be useful as additional documentation, with the output of As maintainer of a contrib project, you obviously have final say over what goes into the releases. |
|
@paf31 Thanks! It's really helpful. The generated output is in I'll work on getting some tests together this week. |
|
Could you enable travis for this repo? I'm not an admin, so it looks like I can't do it. |
|
Travis is enabled now. You might have to push again or something to get it to build the PR though, I think? |
|
I've added the |
|
Looks like tests are passing too. |
|
Yep, looking good! |
|
If there are no objections, I'll release this in about 24 hours. |
|
Looks good to me 👍 |
This is the same pull request from the following link, factored out into a separate module.
purescript/purescript-strings#57
In commit f8470e5, I update the documentation to be PureScript style instead of Haskell style.
There are a couple TODOs left in the code, but they can all be completed after this is merged in and released.