Port learning repo's syntax examples to this repo#52
Merged
thomashoneyman merged 5 commits intopurescript-contrib:masterfrom Jun 5, 2020
JordanMartinez:addExamples
Merged
Port learning repo's syntax examples to this repo#52thomashoneyman merged 5 commits intopurescript-contrib:masterfrom JordanMartinez:addExamples
thomashoneyman merged 5 commits intopurescript-contrib:masterfrom
JordanMartinez:addExamples
Conversation
Contributor
|
Thanks for adding this, @JordanMartinez -- I'm sorry for such a late response, I didn't realize I never followed up. I'm glad to add examples to this repository, and I agree that adding CI would be nice. What do you think of moving these examples into a tests file, which would also give the benefit of a compiler-checked assertion of the output of these functions? For example: module Test.Example where
...examples...We could then trim the README to have a couple syntax examples with a longer explanation of how they work + point users to the tests for a larger set of examples (that are tested to work, unlike READMEs which tend to fall out of date). |
Contributor
Author
|
How's this?
I don't think the module should be |
thomashoneyman
approved these changes
Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
While adding CI would be nice, this is at least better than what we have now.