Fix the token definition for Java style#86
Merged
thomashoneyman merged 1 commit intopurescript-contrib:masterfrom Jan 24, 2020
matoruru:master
Merged
Fix the token definition for Java style#86thomashoneyman merged 1 commit intopurescript-contrib:masterfrom matoruru:master
thomashoneyman merged 1 commit intopurescript-contrib:masterfrom
matoruru:master
Conversation
thomashoneyman
approved these changes
Jan 21, 2020
Contributor
There was a problem hiding this comment.
This correctly restricts identifiers to only begin with a "Java letter" (a-z, _, and $) and only contain "Java letters" and "Java digits" (0-9) according to the Java spec on identifiers.
With that in mind I'm approving this, but I'll wait a day for other maintainers to comment before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix the token definition to follow Java language style.
$and_for Java identifier at wherever we want.'for Java identifier.Where should the reviewer start?
How should this be manually tested?
I added the test code.
Other Notes: