feat: add MonadAsk & MonadReader instances#208
Merged
jamesdbrock merged 5 commits intopurescript-contrib:mainfrom Oct 20, 2022
bentongxyz:main
Merged
feat: add MonadAsk & MonadReader instances#208jamesdbrock merged 5 commits intopurescript-contrib:mainfrom bentongxyz:main
jamesdbrock merged 5 commits intopurescript-contrib:mainfrom
bentongxyz:main
Conversation
jamesdbrock
approved these changes
Oct 16, 2022
Member
jamesdbrock
left a comment
jamesdbrock
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This looks correct to me, and I believe those instances can be very useful for ParserT. I'll leave the PR open for a few days to see if anyone else has an opinion.
garyb
approved these changes
Oct 16, 2022
natefaubion
reviewed
Oct 17, 2022
natefaubion
reviewed
Oct 17, 2022
Co-authored-by: Nathan Faubion <[email protected]>
Co-authored-by: James Brock <[email protected]>
Member
|
Thanks @bentongxyz ! |
Contributor
Author
|
@jamesdbrock a joy to code on Purescript and this parsing library thanks to you all amazing people behind them. I am just happy to contribute something useful back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
add MonadAsk & MonadReader instances
Checklist: