Make <?> infixr and update prec to 2#163
Merged
thomashoneyman merged 2 commits intopurescript-contrib:mainfrom Mar 24, 2022
JordanMartinez:fix-alt-breakage
Merged
Make <?> infixr and update prec to 2#163thomashoneyman merged 2 commits intopurescript-contrib:mainfrom JordanMartinez:fix-alt-breakage
thomashoneyman merged 2 commits intopurescript-contrib:mainfrom
JordanMartinez:fix-alt-breakage
Conversation
JordanMartinez
added
type: breaking change
Contributor
Author
Contributor
Author
|
I don't think setting |
Contributor
|
Wait, sorry — I was about to say the same thing 😓. This isn't exercised in tests at all in this library. We need to add it there. Sorry about that, I just assumed it was already used there and would have thrown. |
Contributor
Author
|
No worries! I'll submit another PR. |
Contributor
|
I actually think that this should be 3, on second thought. It having the same precedence as alt means that you can just write things like: foo <?> "ok"
<|> bar <?> "watEven if a formatter will mess it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #161
Checklist: