New module Text.Parsing.Parser.String.Basic#142
Conversation
|
The |
jamesdbrock
force-pushed
the
bugfix-token-float
branch
2 times, most recently
from
9c53c83 to
0c6de10
Compare
jamesdbrock
force-pushed
the
bugfix-token-float
branch
4 times, most recently
from
5b2f645 to
eb81202
Compare
New functions - `Parser.String.Basic.number` - `Parser.String.Basic.intDecimal` Moved the `Parser.Token` parsers `digit`, `hexDigit`, `octDigit`, `upper`, `space`, `letter`, `alphaNum` into the new module `Parser.String.Basic`.
jamesdbrock
force-pushed
the
bugfix-token-float
branch
from
eb81202 to
eeb746e
Compare
jamesdbrock
requested review from
JordanMartinez,
robertdp and
thomashoneyman
jamesdbrock
changed the title
|
|
||
| instance alternativeParserT :: Monad m => Alternative (ParserT s m) | ||
|
|
||
| instance monadZeroParserT :: Monad m => MonadZero (ParserT s m) |
There was a problem hiding this comment.
I thought we weren't removing these until v0.15.0 comes out?
There was a problem hiding this comment.
I can't find a reference for this, can you post a link please @JordanMartinez ?
There was a problem hiding this comment.
See purescript/purescript-lists#176
We have a couple of MonadZero issues like that scattered throughout the core and contrib libs.
There was a problem hiding this comment.
There’s a strict requirement that we don’t remove the warning in core libraries, and we’ve largely stuck to that in non-core libraries too. But there’s not a requirement that we keep these in place other than the core org (I’ve removed it elsewhere when making breaking changes 😅)
jamesdbrock
force-pushed
the
bugfix-token-float
branch
from
eeb746e to
0cfe422
Compare
Personally speaking, I don't know why we even have the Haskell and Java parsers included with this library. They feel like they belong in some companion package, like |
|
@jamesdbrock I noticed this released as |
Yeah I've been thinking that too.
I'm re-exporting the functions from the old modules so there's no breaking change. |
3 participants
Description of the change
New module Text.Parsing.Parser.String.Basic
New functions
Parser.String.Basic.numberParser.String.Basic.intDecimalMoved the
Parser.Tokenparsersdigit,hexDigit,octDigit,upper,space,letter,alphaNuminto the new moduleParser.String.Basic.Resolves the issues #73 #115 . Actually it doesn't resolve them directly because we still have the
floattoken parser which was failing to parse correctly. We're keeping thefloattoken parser which is documented to conform to “the grammar rules of the Haskell report,” but who knows if that's really true or not. Instead we've added a newnumberparser for parsing aNumber, which I think is what most people want anyway.Checklist: