Skip to content

Fix warnings revealed by v0.14.1 PS release#112

Merged
thomashoneyman merged 6 commits intopurescript-contrib:mainfrom
JordanMartinez:fixWarnings
Apr 21, 2021
Merged

Fix warnings revealed by v0.14.1 PS release#112
thomashoneyman merged 6 commits intopurescript-contrib:mainfrom
JordanMartinez:fixWarnings

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Apr 19, 2021 •
edited
Loading

Description of the change

Self-explanatory

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Apr 19, 2021

I'm not sure how these warnings should be handled. I'm assuming we should export them?

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:207:1

  207  indentBrackets p = withPos $ pure identity <-/> symbol "[" <+/> p <-/> symbol "]"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentBrackets was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:211:1

  211  indentAngles p = withPos $ pure identity <-/> symbol "<" <+/> p <-/> symbol ">"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentAngles was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:215:1

  215  indentBraces p = withPos $ pure identity <-/> symbol "{" <+/> p <-/> symbol "}"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentBraces was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:219:1

  219  indentParens p = withPos $ pure identity <-/> symbol "(" <+/> p <-/> symbol ")"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentParens was not used, and is not exported.

thomashoneyman
thomashoneyman reviewed Apr 19, 2021
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 14 to 15
- Fix warnings found by v0.14.1 PS release (#112)
- Add dependencies whoes modules are used directly in source code (#112)
Copy link
Contributor

@thomashoneyman thomashoneyman Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix warnings found by v0.14.1 PS release (#112)
- Add dependencies whoes modules are used directly in source code (#112)
- Removed unused names found by v0.14.1 PureScript release (#112 by @JordanMartinez)
- Installed dependencies directly imported into source code that were previously installed transitively (#112 by @JordanMartinez)

Copy link
Contributor Author

@JordanMartinez JordanMartinez Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Apr 19, 2021

@JordanMartinez I'm surprised those warnings aren't showing up in the CI build; shouldn't they cause it to fail if the compiler is warning on them?

Otherwise, we can decide whether we want to export those functions or remove them.

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Apr 20, 2021

@thomashoneyman CI isn't failing because it's still using v0.14.0. Once we update it to v0.14.1, it will fail.

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Apr 20, 2021

Latest commit exports those 4 unused/unexported functions.

@thomashoneyman thomashoneyman merged commit 982a957 into purescript-contrib:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman