Replace Data.Char.Unicode.digitToInt by Data.Char.Unicode.hexDigitToInt and Data.Char.Unicode.isDigit by Data.Char.Unicode.isDecDigit#103
Merged
thomashoneyman merged 3 commits intopurescript-contrib:mainfrom Dec 28, 2020
Conversation
Contributor
Author
|
The build fails because newtype doesn’t depend on safe-coerce in the package set but it compiles with the rc5 branch of my fork: let upstream =
https://raw.githubusercontent.com/kl0tl/package-sets/rc5/src/packages.dhall
in upstream |
Contributor
|
I’m not entirely sure about adding decDigit; I’m going to merge this without it and we can do a follow-up issue to discuss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data.Char.Unicode.digitToInt and Data.Char.Unicode.isDigit were deprecated in purescript-contrib/purescript-unicode#31.
Should we also deprecate Text.Parsing.Parser.Token.digit for a new decDigit function? This would be consistent with the changes in purescript-unicode.