CodePoints uncons? Deprecate drop?

I just noticed that `instance stringStringLike` uses `CodeUnits` for `uncons`.

https://github.com/purescript-contrib/purescript-parsing/blob/3d7976e9182d7125d4658b78629de5c92a6bbd40/src/Text/Parsing/Parser/String.purs#L27-L29

Doesn't that mean that `anyChar` will be wrong for astral characters?

https://github.com/purescript-contrib/purescript-parsing/blob/3d7976e9182d7125d4658b78629de5c92a6bbd40/src/Text/Parsing/Parser/String.purs#L54-L56

Also, the `drop` member of `StringLike` is now unused?


Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CodePoints uncons? Deprecate drop? #109

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	instance stringLikeString :: StringLike String where
	uncons = SCU.uncons
	drop = S.drop

	anyChar = do
	input <- gets \(ParseState input _ _) -> input
	case uncons input of

CodePoints uncons? Deprecate drop? #109

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions