Skip to content

Add text-overflow CSS property#97

Merged
garyb merged 1 commit into
purescript-contrib:masterfrom
vyorkin-forks:feature/text-overflow
Jul 9, 2018
Merged

Add text-overflow CSS property#97
garyb merged 1 commit into
purescript-contrib:masterfrom
vyorkin-forks:feature/text-overflow

Conversation

@vyorkin

@vyorkin vyorkin commented Jul 8, 2018

Copy link
Copy Markdown
Collaborator

This PR adds only basic support for text-overflow (I believe only fade is missing), but should cover most use-cases of this property.

Resolves #96

Comment thread src/CSS/Text/Overflow.purs Outdated
data TextOverflow
= Clip
| Ellipsis
| Placeholder String

@vyorkin vyorkin Jul 8, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't imagine a better name for this.

The <string> to be used to represent clipped text. The string is displayed inside the content area, shortening the size of the displayed text. If there is not enough space to display the string itself, it is clipped.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom maybe?

@vyorkin vyorkin force-pushed the feature/text-overflow branch from e6a3fea to 49fefa0 Compare July 8, 2018 18:00
@vyorkin

vyorkin commented Jul 8, 2018

Copy link
Copy Markdown
Collaborator Author

Renamed placeholder -> custom, rebased

@vyorkin vyorkin force-pushed the feature/text-overflow branch from 49fefa0 to b957552 Compare July 8, 2018 21:01
@garyb garyb merged commit 2183565 into purescript-contrib:master Jul 9, 2018
@vyorkin vyorkin deleted the feature/text-overflow branch July 9, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants