Add more selector combinators#100
Conversation
|
Please, don't merge yet, I'm going to add a couple of tests. |
garyb
left a comment
garyb
left a comment
There was a problem hiding this comment.
A couple of bikesheddy thoughts:
| -- | Maps to `sel1 sel2` in CSS. | ||
| deep :: Selector -> Selector -> Selector | ||
| deep a b = Selector (Refinement []) (Deep a b) | ||
| infix 6 deep as ** |
There was a problem hiding this comment.
Maybe we could change this to |* for a kind of consistency with >, +?
There was a problem hiding this comment.
yeah, I also think this is going to look nicer :)
| -- | depending on the filter. | ||
| with :: Selector -> Refinement -> Selector | ||
| with (Selector (Refinement fs) e) (Refinement ps) = Selector (Refinement (fs <> ps)) e | ||
| infix 6 with as ## |
There was a problem hiding this comment.
We could use & here perhaps, since it expresses combination nicely? I guess it's not done in Haskell since & is an operator there (that operator is actually # in PS 😄)
There was a problem hiding this comment.
yeah, good point, thanks! (btw this might be a breaking change though as this operator was there before)
vyorkin
force-pushed
the
feature/selector-combinators
branch
from
f07c1cb to
bd0debd
Compare
vyorkin
force-pushed
the
feature/selector-combinators
branch
from
bd0debd to
bd25238
Compare
|
Ok, I've added some tests & rebased, should be ready for review. |
garyb
left a comment
garyb
left a comment
There was a problem hiding this comment.
Great 👍
Did you still want to hold off merging until things are updated for -test-unit?
|
Actually I wanted to migrate tests after merging PR's :) is it ok? |
|
Sure thing! |
2 participants
This PR is a 100% port from Clay, no other additions from my side.
Resolves #98