Ch10 showNumber fix and more FFI examples#57
Merged
hdgarrood merged 1 commit intopurescript-contrib:masterfrom Apr 10, 2020
Merged
Ch10 showNumber fix and more FFI examples#57hdgarrood merged 1 commit intopurescript-contrib:masterfrom
hdgarrood merged 1 commit intopurescript-contrib:masterfrom
Conversation
Collaborator
hdgarrood
approved these changes
Mar 21, 2020
text/chapter10.md
Outdated
| Notice that `shout` is compiled to a (curried) function of two arguments, not one. The first argument `dict` is the type class dictionary for the `Show` constraint. `dict` contains the implementation of the `show` function for the type `a`. | ||
|
|
||
| We can call this function from JavaScript by passing an explicit type class dictionary from the Prelude as the first parameter: | ||
| We can call this function from JavaScript by passing an explicit type class dictionary from the `Data.Show` as the first parameter: |
There was a problem hiding this comment.
I’d probably remove the “the” before the module name here, personally
Member
Author
There was a problem hiding this comment.
Good catch. Applied suggestion in latest force-push
milesfrain
force-pushed
the
ch10-ffi-examples
branch
from
190c8ea to
bbdb205
Compare
Member
Author
I agree. Bumped the book thread to nag about transferring to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the FFI confusion discussed in these threads: