Add NonEmptyArray and NonEmptyList instances#61
Merged
thomashoneyman merged 1 commit intomasterfrom Aug 28, 2019
Merged
Conversation
garyb
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Closes #58 by adding instances for
NonEmptyArrayandNonEmptyList.I also considered adding
FoldableandNonEmpty Foldableinstances, as suggested in #25, but this would cause overlapping instances with existing foldable structures (Array,List). Any suggestions for this -- instance chains, or skip altogether?Where should the reviewer start?
Additions to the
Encode.ClassandDecode.Classmodules, plus new tests added to the nonempty suite with QuickCheck.Other Notes:
I also did some minor cleanup to make the modules' coding style more consistent, but without making changes to functionality.