Add encode/decode instances for Identity a#54
Merged
thomashoneyman merged 1 commit intopurescript-contrib:masterfrom May 27, 2019
ajnsit:identityInstances
Merged
Add encode/decode instances for Identity a#54thomashoneyman merged 1 commit intopurescript-contrib:masterfrom ajnsit:identityInstances
Identity a#54thomashoneyman merged 1 commit intopurescript-contrib:masterfrom
ajnsit:identityInstances
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds trivial encode/decode instances for
Identity a. I ran into this when trying to encode a data type that looks like this -When the entity has a Guid it can be persisted as
Entity Identity. This is a very common pattern.However in the absence of an encode instance for
Identity a, I have to manually encodeEntitywhile unwrapping the guid field, which is a bit ugly.