Skip to content

Add two extra exports#50

Merged
garyb merged 2 commits into
purescript-contrib:mainfrom
amesgen:extra-exports
Jan 9, 2023
Merged

Add two extra exports#50
garyb merged 2 commits into
purescript-contrib:mainfrom
amesgen:extra-exports

Conversation

@amesgen

@amesgen amesgen commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Description of the change
Thanks for these useful bindings! This is a small ad-hoc PR to add support for two missing options:


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@amesgen

amesgen commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

CI failure looks unrelated, should I try to fix it in this PR?

@garyb

garyb commented Jan 9, 2023

Copy link
Copy Markdown
Member

Ah yeah, if you could that'd be great - the package set just needs updating to a value that actually exists.

So prepare-0.15 -> psc-0.15.4-20230105 in

https://raw.githubusercontent.com/purescript/package-sets/prepare-0.15/src/packages.dhall
would do the trick!

@garyb

garyb commented Jan 9, 2023

Copy link
Copy Markdown
Member

Thanks!

@garyb garyb merged commit 79d371b into purescript-contrib:main Jan 9, 2023
@amesgen amesgen deleted the extra-exports branch January 9, 2023 14:04
@amesgen

amesgen commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, published: purescript/registry#150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants