Skip to content

Introduce purs-tidy formatter#46

Merged
thomashoneyman merged 4 commits into
mainfrom
trh/purs-tidy
Nov 11, 2021
Merged

Introduce purs-tidy formatter#46
thomashoneyman merged 4 commits into
mainfrom
trh/purs-tidy

Conversation

@thomashoneyman

@thomashoneyman thomashoneyman commented Nov 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of the change
Introduces the purs-tidy formatter. This formatter is a lightly opinionated tool we use to maintain a consistent style in the contrib libraries.

We ordinarily restrict to tools provided by the core or contrib projects. This tool is not, but it was developed and is maintained by core team members, and because it's a formatter it can't block maintenance or release of this library even in the event something goes catastrophically wrong with it.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@thomashoneyman

thomashoneyman commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

@purescript-contrib/maintainers This is a draft pull request demonstrating introducing the purs-tidy formatter. This has been opened by an automated script, and if it looks good then all we really need to do is evaluate formatting decisions made by purs-tidy to fix up anything particularly wonky before committing.

If the formatting looks fine then please go ahead and approve, and if it doesn't then please comment on the PR with a suggested fix. I'll do the pull requests in batches and will leave each batch open for a few days for review feedback before merging them in.

If you would like to not be assigned or pinged when new batches go up, please let me know and I'll remove you!

@thomashoneyman thomashoneyman marked this pull request as ready for review November 10, 2021 21:51
JordanMartinez
JordanMartinez reviewed Nov 10, 2021
View reviewed changes

@JordanMartinez JordanMartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but otherwise LGTM.

Comment thread src/Ace/KeyBinding.purs
Comment thread src/Ace/Types.purs Outdated
Comment thread src/Ace/Types.purs Outdated
@thomashoneyman thomashoneyman merged commit d185a5f into main Nov 11, 2021
@thomashoneyman thomashoneyman deleted the trh/purs-tidy branch November 11, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesdbrock jamesdbrock Awaiting requested review from jamesdbrock

@garyb garyb Awaiting requested review from garyb

1 more reviewer

@JordanMartinez JordanMartinez JordanMartinez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomashoneyman @JordanMartinez