-
Notifications
You must be signed in to change notification settings - Fork 80
Support exclude files #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exclude files #613
Conversation
|
Thanks for putting this together @i-am-the-slime! I am on holiday away from screens this week, so I'll be able to review all of this once I'm back on Sunday 🙂 |
|
@i-am-the-slime the dependency order is |
|
I think we should use the same names (include / exclude), which would mean changing the Manifest type (and the associated dhall spec and description in SPEC.md). If you’d like to do that, great! If you’d rather I do it since I know where all the relevant files are then I can — just let me know. |
|
@thomashoneyman I won't say no to this offer. Especially because I'm having trouble with the new spago in IntelliJ which is what I'm used to using these days. |
|
I ended up going with |
SPEC.md
Outdated
| Note: | ||
|
|
||
| - Globs you provide at the `includeFiles` and `excludeFiles` keys must contain only `*`, `**`, `/`, `.`, `..`, and characters for Linux file paths. It is not possible to negate a glob (ie. the `!` character), and globs cannot represent a path out of the package source directory. | ||
| - When packaging your project source, the registry will first "include" your `src` directory and always-included files such as your `purs.json` file. Then it will include files which match globs indicated by the `includeFiles` key. Finally, it will apply the excluding globs indicated by the `excludeFiles` key to the included files (always-included files cannot be excluded). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should link to the list of "always included" files if we have it anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do, and I've added links to both the always-included and always-ignored files.
Co-authored-by: Fabrizio Ferrai <[email protected]>
Adds support for exclude files which enables colocation (#602)
excludeFilesis an array of globs. The corresponding expanded paths will be subtracted from all included paths (implicit and explicit viafiles).That way it's possible to keep related files close together but not ship them in the package 🥳.
Right now this depends on a forked version of spaghetto which depends on this fork. I'm not sure in what order this could be merged.