Skip to content

Generate changelog and add PR template#13

Merged
JordanMartinez merged 3 commits into
purescript:masterfrom
JordanMartinez:addChangelog
Jan 10, 2021
Merged

Generate changelog and add PR template#13
JordanMartinez merged 3 commits into
purescript:masterfrom
JordanMartinez:addChangelog

Conversation

@JordanMartinez

Copy link
Copy Markdown
Contributor

@thomashoneyman

thomashoneyman commented Jan 10, 2021

Copy link
Copy Markdown
Member

The CI failure is unrelated to this PR (but ought to be fixed pre-release)

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

Let's just fix it in this PR.

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

Hm... CI fails because fun deps aren't propagated:

[1/1 NoInstanceFound] test/Main.purs:12:1

      v
  12  instance newtypeRecordNewtype ::
  13    TypeEquals inner { message :: String }
  14      => Newtype RecordNewtype inner
                                       ^
  
  No type class instance was found for
  
    Prim.Coerce.Coercible inner0
                          { message :: String
                          }
  
  while solving type class constraint
  
    Prim.Coerce.Coercible RecordNewtype
                          inner0
  
  while checking that expression #dict Coercible
    has type Coercible$Dict @Type RecordNewtype inner0
  in value declaration newtypeRecordNewtype
  
  where inner0 is a rigid type variable
          bound at (line 0, column 0 - line 0, column 0)

           Src   Lib   All
Warnings   0     0     0  
Errors     1     0     1  

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

I'm going to remove the previous commit so that this only focuses on the changelog and PR template.

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

Commit has been removed.

@JordanMartinez JordanMartinez merged commit 5ec563c into purescript:master Jan 10, 2021
@JordanMartinez JordanMartinez deleted the addChangelog branch January 10, 2021 23:02
@JordanMartinez

Copy link
Copy Markdown
Contributor Author

I'm addressing the Newtype instance issue in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants