Allow full Number range for chooseFloat#97
Merged
thomashoneyman merged 2 commits intopurescript:masterfrom Dec 23, 2020
Merged
Conversation
Contributor
Author
|
Somewhat related, shouldn't there be a |
Contributor
|
I’m not really a fan of a bounded-like type class where bottom/top are finite. What laws would it satisfy? Would it make sense for any types other than Number? |
hdgarrood
approved these changes
Feb 11, 2019
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Looks good to me; I just have one small comment.
| quickCheck $ 4 >? 3 | ||
| quickCheckFail $ 4 <=? 3 | ||
|
|
||
| randomSample (MGen.chooseFloat ((-1.7976931348623157e+308)) (1.7976931348623157e+308)) >>= assert <<< all isFinite |
Contributor
There was a problem hiding this comment.
Can you add a log statement just before this line so that if this fails, it will be a little clearer as to why?
Contributor
|
This looks good to me. Just curious but why wasn't this PR merged previously? |
JordanMartinez
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.