Removes costrong and cochoice from costar#38
Merged
thomashoneyman merged 2 commits intopurescript:masterfrom Dec 17, 2020
Merged
Removes costrong and cochoice from costar#38thomashoneyman merged 2 commits intopurescript:masterfrom
thomashoneyman merged 2 commits intopurescript:masterfrom
Conversation
Member
|
Thanks, @mikesol! This looks perfectly fine to me. Thanks for the PR :) |
thomashoneyman
approved these changes
Dec 11, 2020
Member
thomashoneyman
left a comment
There was a problem hiding this comment.
👍. Also see: purescript-contrib/purescript-profunctor-lenses#120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I cannot compile with the new syntax, so I hope this PR does not break anything. As there are not any tests, we'll say it passes the tests :-D