Skip to content

Add unionWith#21

Merged
JordanMartinez merged 4 commits into
purescript:masterfrom
Zelenya:patch-1
Dec 28, 2020
Merged

Add unionWith#21
JordanMartinez merged 4 commits into
purescript:masterfrom
Zelenya:patch-1

Conversation

@Zelenya

@Zelenya Zelenya commented Dec 23, 2020

Copy link
Copy Markdown
Contributor

It's seems like it could be useful. Right now I use a couple of newtypes with different semigroup instances for this

@kl0tl kl0tl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow us to implement the Semigroup instance with append = unionWith (<>) but this is breaking (see #19).

Comment thread src/Foreign/Object.purs Outdated
Comment thread src/Foreign/Object.purs Outdated
Comment thread test/Test/Foreign/Object.purs Outdated

@kl0tl kl0tl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kl0tl

kl0tl commented Dec 28, 2020

Copy link
Copy Markdown
Member

We merged #19 so we could implement the Semigroup instance with append = unionWith (<>) in this pull request.

Tests should pass with a rebase once #22 is merged.

@JordanMartinez JordanMartinez merged commit 6427ae9 into purescript:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants