Introduce monad transformer FT#74
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Feb 3, 2021
Merged
Conversation
garyb
added
the
type: breaking change
garyb
reviewed
Nov 11, 2018
Member
|
This looks like something we should try to do with the 0.14 compiler release, is there any objection? |
57 tasks
Contributor
|
Any updates on this PR? |
thomashoneyman
approved these changes
Jan 27, 2021
JordanMartinez
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows running
FTatop any monad, not justIdentity.History and usecase: purescript-corefn uses purescript-foreign to parse the corefn produced by PureScript. With non-trivial programs the corefn quickly grows large enough to blow the stack while parsing. By recovering the ability to change out the underlying monad, we can instead run on top of
Trampolineand evaluate usingrunTrampoline, thereby recovering stack safety.