Skip to content

Drop deprecated group' and empty#219

Merged
thomashoneyman merged 3 commits into
purescript:masterfrom
JordanMartinez:dropDeprecated
Mar 17, 2022
Merged

Drop deprecated group' and empty#219
thomashoneyman merged 3 commits into
purescript:masterfrom
JordanMartinez:dropDeprecated

Conversation

@JordanMartinez

@JordanMartinez JordanMartinez commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

Description of the change

Drops deprecated entities.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez

JordanMartinez commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

🏓 @thomashoneyman

@thomashoneyman

thomashoneyman commented Mar 17, 2022

Copy link
Copy Markdown
Member

You need to fix the import errors, but otherwise 👍

[1/3 UnusedImport] src/Data/Array.purs:150:1

  150  import Prim.TypeError (class Warn, Text)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  The import of Prim.TypeError is redundant

[2/3 UnusedImport] src/Data/Array/NonEmpty.purs:136:1

  136  import Prim.TypeError (class Warn, Text)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  The import of Prim.TypeError is redundant

[3/3 UnusedImport] src/Data/Array/ST.purs:36:1

  36  import Prim.TypeError (class Warn, Text)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  The import of Prim.TypeError is redundant

@thomashoneyman thomashoneyman merged commit 98a2d43 into purescript:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman