replace FFI cons, snoc, drop, take with purescript implementations#180
Merged
Conversation
hdgarrood
reviewed
Oct 6, 2020
hdgarrood
left a comment
hdgarrood
left a comment
Contributor
There was a problem hiding this comment.
Completely agree with reducing the amount of FFI here, yes.
sharno
force-pushed
the
replace-foreigns
branch
from
a8f478f to
725cab7
Compare
hdgarrood
approved these changes
Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel it's a good idea to replace FFI implementations with equivalent Purescript ones, mainly to make it easier for other backends to use the library with less FFI code and for the type safety. What do you think?