glob-test.sh outputs the following:

$ stack exec bash glob-test.sh 
env info
0.15.14 [development build; commit: e25c476c08c2e134f5d369326060be2f0d9ef583 DIRTY]
z
├── Foo.purs
├── globsAll
├── globsNoFoo
└── src
    ├── Bar
    │   └── Baz.purs
    └── Bar.purs

2 directories, 5 files
---
module Foo where
foo = 1 :: Int
---
module Bar where
bar = 1 :: Int
---
module Bar.Baz where
baz = 1 :: Int
---
Result
z/out1
├── Bar.Baz
│   ├── externs.cbor
│   └── index.js
├── cache-db.json
├── Foo
│   ├── externs.cbor
│   └── index.js
└── package.json

2 directories, 6 files
z/out2
├── Bar
│   ├── externs.cbor
│   └── index.js
├── Bar.Baz
│   ├── externs.cbor
│   └── index.js
├── cache-db.json
├── Foo
│   ├── externs.cbor
│   └── index.js
└── package.json

3 directories, 8 files
z/out3
├── Bar
│   ├── externs.cbor
│   └── index.js
├── Bar.Baz
│   ├── externs.cbor
│   └── index.js
├── cache-db.json
├── Foo
│   ├── externs.cbor
│   └── index.js
└── package.json

3 directories, 8 files
z/out4
├── Bar
│   ├── externs.cbor
│   └── index.js
├── Bar.Baz
│   ├── externs.cbor
│   └── index.js
├── cache-db.json
├── Foo
│   ├── externs.cbor
│   └── index.js
└── package.json

3 directories, 8 files
SOURCE_GLOBS output different from EXPECTED
Expected: purs compile: No files found using pattern: z/test/**/*.purs
[1 of 2] Compiling Bar.Baz
[2 of 2] Compiling Foo
SOURCE_GLOBS: purs compile: No files found using pattern: z/test/**/*.purs
[1 of 3] Compiling Foo
[2 of 3] Compiling Bar
[3 of 3] Compiling Bar.Baz

I tried this script on master and the EXPECTED globs also exclude the [2 of 3] Compiling Bar line. I think there's a bug in the glob handling.

The above issue was due to z/src/**/*.purs being expanded by the shell to z/src/Bar/Baz.purs before the compiler ever received the glob. Wrapping that in single quotes disables that behavior, such that the compiler receives the full glob correctly.

This PR is ready for an initial review now.

However, I noticed an issue somewhat related to this PR with how we produce our globs. In #4480, we added the option to exclude files from the initial set of files produced by the globs. However, this change was only done in the compile command. So, other commands that use globs like docs, graph, hierarchy, and repl don't support the exclude-files flag.

Moreover, should the format of the glob file added here also include some code for the excldue-files globs, such that one could write something like the following where lines prefixed with + act like our current input globs and - act like the exclude-files arg?

+ src/**/*.purs
- src/Spec/**/*.purs

Moreover, should the format of the glob file added here also include some code for the excldue-files globs, such that one could write something like the following where lines prefixed with + act like our current input globs and - act like the exclude-files arg?

I think we should ship the feature as implemented, and we can issue a future patch if there's the need for covering more scope. I don't think the exclude-files feature is in high usage at the moment.

The patch is good, but what about the glob-test.sh file? We should either use it from a test suite, or remove it since it will rot if not machine-checked regularly.

I've added it to our tests, but made it only run on Linux.

However, I noticed an issue somewhat related to this PR with how we produce our globs. In #4480, we added the option to exclude files from the initial set of files produced by the globs. However, this change was only done in the compile command. So, other commands that use globs like docs, graph, hierarchy, and repl don't support the exclude-files flag.

I've updated this PR to also add --exclude-files and --source-globs to more commands.

Now that CI builds, can this get another review due to adding both --source-globs and --exclude-files to the other commands?

Anything else? Or is this good to merge?

I left one nit in the changelog, but otherwise it's good to go.

Fixed!